Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointing): Add pre-defined scroll scaler and mouse scroll tests #2759

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

caksoylar
Copy link
Contributor

Similar to &zip_xy_scaler, add a &zip_scroll_scaler to scale wheel/hwheel movements. There is also both &zip_xy_transform and &zip_scroll_transform, so it seems to make sense to have &zip_scroll_scaler pre-defined.

Also take the opportunity to add some mouse scroll tests, including for &zip_scroll_scaler and &zip_scroll_transform.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@caksoylar caksoylar added tests pointers Pointer related functionality labels Jan 10, 2025
@caksoylar caksoylar requested review from a team as code owners January 10, 2025 07:51
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely PR! Thanks!

@petejohanson petejohanson merged commit 0f7c112 into zmkfirmware:main Feb 4, 2025
46 checks passed
@caksoylar caksoylar deleted the feat/add-scroll-scaler branch February 4, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pointers Pointer related functionality tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants